1.00.66 Editions / JUNK CODE

Here the changes and the fix for each one of the JUNK piece of coded founded under 1.00.66 if you know more parts that are JUNK and need to be fixed please tell me, so i can add into the list.

Why we do this? for get a cleaner GS.

CHANGE_01:
Procedure: GameServ.CObjUseSkill::SkillChangeUse
0042A8B9 /EB 17 JMP SHORT GameServ.0042A8D2
FIX_01:
0042A8B9 8B4D 98 MOV ECX,DWORD PTR SS:[EBP-68]
0042A8BC 8B01 MOV EAX,DWORD PTR DS:[ECX]
EXTRA_JUNK_01:
0042A8D2 > \8B55 98 MOV EDX,DWORD PTR SS:[EBP-68]
0042A8D5 . 52 PUSH EDX
0042A8D6 . 90 NOP
0042A8D7 . 90 NOP
0042A8D8 . 90 NOP
0042A8D9 . 90 NOP
0042A8DA . 90 NOP
0042A8DB . 8B55 98 MOV EDX,DWORD PTR SS:[EBP-68]
0042A8DE . 8B02 MOV EAX,DWORD PTR DS:[EDX]
0042A8E0 . 50 PUSH EAX
0042A8E1 . B9 D87B6E07 MOV ECX,GameServ.076E7BD8
0042A8E6 . E8 BB6BFDFF CALL GameServ.004014A6
0042A8EB .^ EB DC JMP SHORT GameServ.0042A8C9
BUG_01: NO

CHANGE_02:
Procedure: PKCheck
004B9BB5 >^E9 9EFEFFFF JMP GameServ.004B9A58
FIX_02:
004B9BB5 |> \8B55 0C MOV EDX,[ARG.2]
004B9BB8 |. 52 PUSH EDX
004B9BB9 |. 8B45 08 MOV EAX,[ARG.1]
004B9BBC |. 50 PUSH EAX
EXTRA_JUNK_02:
004B9A58 8B4D 08 MOV ECX,DWORD PTR SS:[EBP+8]
004B9A5B 51 PUSH ECX
004B9A5C 8B4D 0C MOV ECX,DWORD PTR SS:[EBP+C]
004B9A5F 51 PUSH ECX
004B9A60 90 NOP
004B9A61 90 NOP
004B9A62 90 NOP
004B9A63 90 NOP
004B9A64 90 NOP
004B9A65 83F8 00 CMP EAX,0
004B9A68 0F85 64050000 JNZ GameServ.004B9FD2
004B9A6E 8B55 0C MOV EDX,DWORD PTR SS:[EBP+C]
004B9A71 52 PUSH EDX
004B9A72 8B45 08 MOV EAX,DWORD PTR SS:[EBP+8]
004B9A75 E9 40010000 JMP GameServ.004B9BBA
BUG_02: YES PROVOKE NO PVP UNDER SERVER

CHANGE_03:
Procedure: GameServ.gObjGameClose
004E5F43 ^\EB 8B JMP SHORT GameServ.004E5ED0
FIX_03:
004E5F43 8B45 FC MOV EAX,DWORD PTR SS:[EBP-4]
004E5F46 8378 04 03 CMP DWORD PTR DS:[EAX+4],3
EXTRA_JUNK_03:
004E5ED0 8B4D 08 MOV ECX,DWORD PTR SS:[EBP+8]
004E5ED3 51 PUSH ECX
004E5ED4 52 PUSH EDX
004E5ED5 90 NOP
004E5ED6 90 NOP
004E5ED7 90 NOP
004E5ED8 90 NOP
004E5ED9 90 NOP
004E5EDA 8B45 FC MOV EAX,DWORD PTR SS:[EBP-4]
004E5EDD EB 67 JMP SHORT GameServ.004E5F46
BUG_03: NON TESTED

CHANGE_04:
Procedure: PKInfoSet
004EB2DA /E9 83050000 JMP GameServ.004EB862
FIX_04:
004EB2DA 8B45 0C MOV EAX,DWORD PTR SS:[EBP+C]
004EB2DD 33C9 XOR ECX,ECX
004EB2DF 8A88 31010000 MOV CL,BYTE PTR DS:[EAX+131]
EXTRA_JUNK_04:
004EB861 CC INT3
004EB862 8B45 0C MOV EAX,DWORD PTR SS:[EBP+C]
004EB865 50 PUSH EAX
004EB866 90 NOP
004EB867 90 NOP
004EB868 90 NOP
004EB869 90 NOP
004EB86A 90 NOP
004EB86B 83F8 01 CMP EAX,1
004EB86E ^ 74 E9 JE SHORT GameServ.004EB859
004EB870 8B45 0C MOV EAX,DWORD PTR SS:[EBP+C]
004EB873 33C9 XOR ECX,ECX
004EB875 ^ E9 65FAFFFF JMP GameServ.004EB2DF
BUG_04: NON TESTED

CHANGE_05:
Procedure: CItem:Value
005252B7 /E9 34040000 JMP GameServ.005256F0
FIX_05:
005252B7 817D EC 005ED0B2 CMP DWORD PTR SS:[EBP-14],B2D05E00
005252BE 76 0E JBE SHORT GameServ.005252CE
EXTRA_JUNK_05:
005256F0 8B55 FC MOV EDX,DWORD PTR SS:[EBP-4]
005256F3 0FBF42 06 MOVSX EAX,WORD PTR DS:[EDX+6]
005256F7 99 CDQ
005256F8 83E2 1F AND EDX,1F
005256FB 03C2 ADD EAX,EDX
005256FD C1F8 05 SAR EAX,5
00525700 50 PUSH EAX
00525701 8B55 FC MOV EDX,DWORD PTR SS:[EBP-4]
00525704 0FBF42 06 MOVSX EAX,WORD PTR DS:[EDX+6]
00525708 50 PUSH EAX
00525709 6BC0 70 IMUL EAX,EAX,70
0052570C 05 600CFC0C ADD EAX,GameServ.0CFC0C60
00525711 50 PUSH EAX
00525712 8B45 EC MOV EAX,DWORD PTR SS:[EBP-14]
00525715 50 PUSH EAX
00525716 90 NOP
00525717 90 NOP
00525718 90 NOP
00525719 90 NOP
0052571A 90 NOP
0052571B 83F8 00 CMP EAX,0
0052571E 74 03 JE SHORT GameServ.00525723
00525720 8945 EC MOV DWORD PTR SS:[EBP-14],EAX
00525723 817D EC 005ED0B2 CMP DWORD PTR SS:[EBP-14],B2D05E00
0052572A ^ E9 8FFBFFFF JMP GameServ.005252BE
BUG_05: NON TESTED


CHANGE_06:
Procedure: GameServ.BufferItemtoConvert3
00528AB4 90 NOP
00528AB5 90 NOP
FIX_06:
00528AB4 /75 1C JNZ SHORT GameServ.00528AD2
EXTRA_JUNK_06:
NOTHING
BUG_06: NON TESTED

CHANGE_07:
Procedure: GameServ.DGGetWarehouseList
0042B6C4 90 NOP
0042B6C5 90 NOP
FIX_07:
0042B6C4 /75 26 JNZ SHORT GameServ.0042B6EC
EXTRA_JUNK_07:
NOTHING
BUG_07: NON TESTED

CHANGE_08:
Procedure: GameServ.DGGetWarehouseList
0042B917 90 NOP
0042B918 90 NOP
0042B919 90 NOP
0042B91A 90 NOP
0042B91B 90 NOP
0042B91C 90 NOP
0042B91D 90 NOP
0042B91E 90 NOP
0042B91F 90 NOP
0042B920 90 NOP
0042B921 90 NOP
0042B922 90 NOP
0042B923 90 NOP
0042B924 90 NOP
0042B925 90 NOP
FIX_08:
0042B917 F6C4 41 TEST AH,41
0042B91A 75 0A JNZ SHORT GameServ.0042B926
0042B91C C785 48FFFFFF 00004040 MOV DWORD PTR SS:[EBP-B8],40400000
EXTRA_JUNK_08:
NOTHING
BUG_08: NON TESTED